Make Buffer read*/write* native functions with a DFG/FTL intrinsic - #35343
Open
Jarred-Sumner wants to merge 26 commits into
Open
Make Buffer read*/write* native functions with a DFG/FTL intrinsic#35343Jarred-Sumner wants to merge 26 commits into
Jarred-Sumner wants to merge 26 commits into
Claude / Claude Code Review
completed
Jul 24, 2026 in 22m 50s
Code review found 2 potential issues
Found 2 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | scripts/build/deps/webkit.ts:13 |
WEBKIT_VERSION pinned to an ephemeral preview-PR build tag |
Annotations
Check warning on line 13 in scripts/build/deps/webkit.ts
claude / Claude Code Review
WEBKIT_VERSION pinned to an ephemeral preview-PR build tag
Reminder: `WEBKIT_VERSION` is pinned to the ephemeral preview tag `autobuild-preview-pr-330-be77ad70` for the not-yet-merged oven-sh/WebKit#330 (the PR description says the WebKit dependency is 'TBD', and commit 77ba5319 confirms it's temporary). Once WebKit#330 merges, this needs to be swapped for the real merged commit hash before landing — `autobuild-preview-*` release artifacts are typically pruned when the underlying PR closes, at which point `prebuiltUrl()` will 404 and `bun bd` will fail
Loading