WebKit: skip eager timezone prewarm in VM::VM (1.3.14 startup regression) - #35258
Closed
robobun wants to merge 3 commits into
Closed
WebKit: skip eager timezone prewarm in VM::VM (1.3.14 startup regression)#35258robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Jul 23, 2026 in 13m 3s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/intl/intl.test.ts:331 |
Main-thread probe() pre-warms the process-global timezone cache before Workers can race |
Annotations
Check warning on line 331 in test/js/web/intl/intl.test.ts
claude / Claude Code Review
Main-thread probe() pre-warms the process-global timezone cache before Workers can race
In `[probe(), ...await Promise.all(workers)]`, array elements evaluate left-to-right, so `probe()` runs synchronously on the main thread's already-constructed VM *before* the `await` yields — while the 8 Workers are still spinning up threads and fresh VMs. The main thread therefore almost deterministically wins the process-global `std::call_once` for `initializeAvailableTimeZones`, so the Workers observe an already-filled cache instead of racing on cold init. Consider `const wr = await Promise.a
Loading