Skip to content

Ban <iostream> from release builds and drop it from bun-uws - #35256

Merged
Jarred-Sumner merged 13 commits into
mainfrom
farm/d433c90c/drop-uws-iostream
Jul 24, 2026
Merged

Ban <iostream> from release builds and drop it from bun-uws#35256
Jarred-Sumner merged 13 commits into
mainfrom
farm/d433c90c/drop-uws-iostream

Merge branch 'main' into farm/d433c90c/drop-uws-iostream

f58b0fd
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 23, 2026 in 20m 12s

Code review found 1 important issue

Found 4 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important scripts/build/deps/webkit.ts:6 Merge f58b0fd reverted WEBKIT_VERSION to a pre-#320 sha; release build will hit the new iostream #error shim

Annotations

Check failure on line 6 in scripts/build/deps/webkit.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Merge f58b0fd1 reverted WEBKIT_VERSION to a pre-#320 sha; release build will hit the new iostream #error shim 

The merge commit f58b0fd1 resolved the `webkit.ts` conflict by keeping main's `WEBKIT_VERSION = a40d462206` (oven-sh/WebKit#315 only) and discarding this branch's `af2e8dc639` (which rolls up #320/#321/#322). Since `a40d462206` predates #320, its prebuilt still ships `simdutf_impl.h` with `#include <iostream>`, so every release TU that pulls `wtf/SIMDUTF.h` via `src/jsc/bindings/helpers.h` (~70 TUs) will hit the new `src/banned-includes/iostream` `#error` shim — every release `build-cpp` lane fa
View more details on Claude