Ban <iostream> from release builds and drop it from bun-uws - #35256
Merged
Claude / Claude Code Review
completed
Jul 23, 2026 in 9m 3s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/internal/source-lints/no-iostream-include.test.ts:32-45 |
no-iostream lint test can pass vacuously |
Annotations
Check warning on line 45 in test/internal/source-lints/no-iostream-include.test.ts
claude / Claude Code Review
no-iostream lint test can pass vacuously
The test's only assertion is `expect(violations).toEqual([])`, which passes vacuously if `glob.scan()` yields nothing (e.g. `repoRoot` resolves wrong after a file move, or a scanned root goes away — Bun's `Glob.scan` on a non-existent `cwd` yields nothing rather than throwing). The four sibling tests in this directory (`shim-stdint-includes.test.ts`, `frozen-nonnull-reborrow.test.ts`, `unsound-erased-box.test.ts`, `expect-call-counter.test.ts`) each guard this with `expect(scanned).toBeGreaterTh
Loading