Ban <iostream> from release builds and drop it from bun-uws - #35256
Merged
Claude / Claude Code Review
completed
Jul 23, 2026 in 10m 32s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/bun-uws/src/TopicTree.h:105-111 |
Stale 'Notify user' comments at checkIteratingSubscriber call sites |
Annotations
Check warning on line 111 in packages/bun-uws/src/TopicTree.h
claude / Claude Code Review
Stale 'Notify user' comments at checkIteratingSubscriber call sites
The two `/* Notify user that they are doing something wrong here */` comments at the `checkIteratingSubscriber(s)` call sites in `subscribe()` and `unsubscribe()` are now stale — commit 76610d36 dropped the `std::cerr` message (and the identical comment) from inside `checkIteratingSubscriber()`, so nothing notifies the user anymore; it just `std::terminate()`s silently. Since this PR already deleted one of the three copies of this comment, the two sibling copies should get the same treatment (de
Loading