Ban <iostream> from release builds and drop it from bun-uws - #35256
Merged
Claude / Claude Code Review
completed
Jul 23, 2026 in 9m 33s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/bun-uws/src/App.h:418-433 |
App.h uses fputs/stderr without including |
Annotations
Check warning on line 433 in packages/bun-uws/src/App.h
claude / Claude Code Review
App.h uses fputs/stderr without including <cstdio>
App.h now calls `fputs(..., stderr)` at three sites but doesn't get its own `#include <cstdio>` — it compiles only via the transitive include from `HttpContext.h`. The other two files that gained `fputs` calls in this PR (`HttpContext.h`, `TopicTree.h`) each got an explicit `<cstdio>`; adding one here too would keep the three edits consistent and follow include-what-you-use.
Loading