bun:ffi: unify integer argument coercion on modular wrap - #35180
Closed
robobun wants to merge 3 commits into
Closed
Claude / Claude Code Review
completed
Jul 22, 2026 in 12m 51s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/ffi/ffi-int-coercion.test.ts:45 |
tempDir not disposed — leaves compiled .so behind |
Annotations
Check warning on line 45 in test/js/bun/ffi/ffi-int-coercion.test.ts
claude / Claude Code Review
tempDir not disposed — leaves compiled .so behind
`tempDir()` returns a Disposable whose `[Symbol.dispose]` rm-rf's the directory, but assigning it to `const dir` (rather than `using dir`) means it's never disposed — `echo.c` and `libecho.so` are left in the OS temp dir after the test file completes. Change to `using dir = tempDir(...)`; `dlopen` has already mmap'd the .so before scope exit and the describe skips Windows, so unlinking is safe.
Loading