node:fs: mark the per-VM Binding box as LSan-ignored (fixes worker-terminate-lifetime.test.ts on main) - #35159
Open
robobun wants to merge 6 commits into
Open
node:fs: mark the per-VM Binding box as LSan-ignored (fixes worker-terminate-lifetime.test.ts on main)#35159robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jul 22, 2026 in 8m 10s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/fs/fs-oom.test.ts:199-200 |
Per-test 60s timeout violates test/CLAUDE.md |
Annotations
Check warning on line 200 in test/js/node/fs/fs-oom.test.ts
claude / Claude Code Review
Per-test 60s timeout violates test/CLAUDE.md
The `60_000` per-test timeout is unnecessary here — the subprocess only runs `require("node:fs")` and exits, which is a few seconds under debug+ASAN+LSan, not an outlier. test/CLAUDE.md:120 says *"Do not set a timeout on tests. Bun already has timeouts"*, and the two heavier ASAN subprocess tests just above (32 MiB allocations, 7 decode paths) don't set one either. Drop the third argument.
Loading