Error.appendStackTrace: don't abort when stackTraceLimit is unset - #35100
Closed
robobun wants to merge 3 commits into
Closed
Error.appendStackTrace: don't abort when stackTraceLimit is unset#35100robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Jul 22, 2026 in 9m 17s
Code review found 1 important issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | test/js/node/v8/capture-stack-trace.test.js:1125-1146 |
Test does not exercise the destination->stackTrace() null guard |
Annotations
Check failure on line 1146 in test/js/node/v8/capture-stack-trace.test.js
claude / Claude Code Review
Test does not exercise the destination->stackTrace() null guard
The new test never exercises the second added guard (`&& destination->stackTrace()`). In both scenarios the *source* error is created while `stackTraceLimit` is already unset (scenario 2's `c` is created while it's still `undefined` from scenario 1), so `source->stackTrace()` is null and the second `if` short-circuits before the new operand is evaluated — deleting that guard would not break this test. Add a case where the source is created *before* unsetting the limit and the destination after,
Loading