Bun.serve: drain a tryEnd response tail before closing on peer FIN - #35088
Merged
Claude / Claude Code Review
completed
Jul 22, 2026 in 17m 49s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/bun-uws/src/HttpContext.h:208-217 |
PR body Scope section stale after conflict resolution: says 'Plain HTTP only' but code now covers TLS |
Annotations
Check warning on line 217 in packages/bun-uws/src/HttpContext.h
claude / Claude Code Review
PR body Scope section stale after conflict resolution: says 'Plain HTTP only' but code now covers TLS
The PR body is stale in the other direction after the conflict resolution: the Scope section still says "Plain HTTP only" with the pre-#35109 `ssl_spill`/`getBufferedAmount()` rationale (and Fix says "every non-SSL HTTP server socket"), but the diff now sets `allow_half_open` unconditionally, the onEnd defer is a plain `else`, both use `hasFullyDrained()` (which the in-code comment says covers the TLS ciphertext spill), and the tests add an `https fetch handler (tryEnd tail)` case. Only the desc
Loading