rust: fix cargo check --tests for bun_parsers and bun_sys after #34820/#35002 - #35068
Closed
robobun wants to merge 7 commits into
Closed
rust: fix cargo check --tests for bun_parsers and bun_sys after #34820/#35002#35068robobun wants to merge 7 commits into
robobun wants to merge 7 commits into
Claude / Claude Code Review
completed
Jul 22, 2026 in 15m 4s
Code review found 3 potential issues
Found 5 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/internal/rust-tests-compile.test.ts:25 |
workspaceReady skip check omits vendor/lolhtml |
| 🟡 Nit | test/internal/rust-tests-compile.test.ts:34-37 |
stdout piped but never drained |
Annotations
Check warning on line 25 in test/internal/rust-tests-compile.test.ts
claude / Claude Code Review
workspaceReady skip check omits vendor/lolhtml
The `workspaceReady` skip check only guards on `build/debug/codegen/build_options.rs`, but cargo cannot resolve the workspace unless `vendor/lolhtml/Cargo.toml` also exists (root `Cargo.toml` has `lol_html = { path = "vendor/lolhtml" }`). The sibling `test/internal/linear-fifo.test.ts` already checks both for exactly this reason ("test-only lanes run a prebuilt binary and lack vendor/lolhtml"); add `&& existsSync(join(repo, "vendor", "lolhtml", "Cargo.toml"))` here to match.
Check warning on line 37 in test/internal/rust-tests-compile.test.ts
claude / Claude Code Review
stdout piped but never drained
`stdout: "pipe"` is set but `proc.stdout` is never drained — only `proc.stderr.text()` and `proc.exited` are awaited. Per REVIEW.md's subprocess-test rule ("drain pipes concurrently … an unread pipe fills the ~64KB OS buffer and deadlocks the child"), either change to `stdout: "ignore"` since the test never inspects it, or add `proc.stdout.text()` to the `Promise.all`.
Loading