bunfig: load global ~/.bunfig.toml for runtime commands; fall back past $XDG_CONFIG_HOME - #34987
Closed
robobun wants to merge 10 commits into
Closed
bunfig: load global ~/.bunfig.toml for runtime commands; fall back past $XDG_CONFIG_HOME#34987robobun wants to merge 10 commits into
robobun wants to merge 10 commits into
Claude / Claude Code Review
completed
Jul 21, 2026 in 29m 18s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/bunfig/bunfig.rs:566-585 |
retry/rerunEach presence-check fix has two collateral regressions |
Annotations
Check warning on line 585 in src/bunfig/bunfig.rs
claude / Claude Code Review
retry/rerunEach presence-check fix has two collateral regressions
The presence-based `test_.get(b"retry").is_some()` guard + counterpart-zeroing added here has two narrow side-effects unrelated to global→local merging: **(a)** a single bunfig with `[test] rerunEach = 0` and `retry = 3` (or both `= 0`) was accepted on main but now hard-fails via `report_bunfig_load_failure → Global::crash()`, since presence is checked regardless of value; **(b)** because `parse_test_command_options` runs before `load_config_with_cmd_args`, `bun test --retry 3` with a local `[te
Loading