Remove dead code from bun_url - #34965
Closed
robobun wants to merge 2 commits into
Closed
Claude / Claude Code Review
completed
Jul 21, 2026 in 9m 4s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/url/lib.rs:933-935 |
name_count field is now dead — should be removed alongside the commented-out caching path |
Annotations
Check warning on line 935 in src/url/lib.rs
claude / Claude Code Review
name_count field is now dead — should be removed alongside the commented-out caching path
The `QueryStringMap.name_count` field (line 903) is now fully orphaned — it's set to `None` at all three construction sites and cloned, but never read anywhere. Since this PR removes `NAME_COUNT_BUF` (which existed for the same commented-out caching path), `name_count` should go too for consistency. Related: `get_name_count()` no longer needs `&mut self` now that the caching write is gone — `&self` suffices.
Loading