Atomics.waitAsync: keep the event loop alive once notify schedules the resolve task - #34911
Closed
robobun wants to merge 3 commits into
Closed
Atomics.waitAsync: keep the event loop alive once notify schedules the resolve task#34911robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Jul 21, 2026 in 13m 15s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/atomics.test.ts:191 |
Tests assert stderr is exactly empty — flaky under ASAN/debug builds |
Annotations
Check warning on line 191 in test/js/web/atomics.test.ts
claude / Claude Code Review
Tests assert stderr is exactly empty — flaky under ASAN/debug builds
Both new subprocess tests assert `expect(stderr).toBe("")` (here and at line 214), which REVIEW.md forbids because ASAN/debug builds can emit benign warnings to stderr and cause spurious CI failures. Since stderr isn't load-bearing for what's being tested, either drop these assertions or fold them into a combined `expect({ stdout, stderr, exitCode }).toEqual({...})` per repo convention.
Loading