timer: assign epoch on heap insert so AbortSignal.timeout fires in creation order - #34895
Merged
Merged
Claude / Claude Code Review
completed
Jul 21, 2026 in 10m 42s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/abort/abort.test.ts:112 |
Test asserts stderr is exactly empty (flaky under ASAN/debug) |
Annotations
Check warning on line 112 in test/js/web/abort/abort.test.ts
claude / Claude Code Review
Test asserts stderr is exactly empty (flaky under ASAN/debug)
This `expect(stderr).toBe("")` will flake on ASAN/debug CI lanes, which emit benign diagnostics to stderr — REVIEW.md explicitly forbids exact-empty stderr assertions for that reason. Drop this line (the `JSON.parse(stdout)` and `exitCode` assertions already prove correctness) or assert a combined `{ stdout, stderr, exitCode }` object via `normalizeBunSnapshot`.
Loading