ci(verify-baseline): parse //@ JSC flags, skip v128 wasm fixtures on x64, re-enable --jit-stress on WebKit changes - #34877
Open
robobun wants to merge 4 commits into
Open
Claude / Claude Code Review
completed
Jul 21, 2026 in 14m 26s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | .buildkite/ci.mjs:749 |
vendor/WebKit/ clause in hasWebKitChanges is dead code |
Annotations
Check warning on line 749 in .buildkite/ci.mjs
claude / Claude Code Review
vendor/WebKit/ clause in hasWebKitChanges is dead code
The `file.startsWith("vendor/WebKit/")` clause can never match: `vendor/` is gitignored (`.gitignore:156`) and WebKit lives there as a separate clone fetched by the build, so the GitHub PR-files API that populates `changedFiles` will never return a path under it. The `scripts/build/deps/webkit.ts` clause (which holds `WEBKIT_VERSION`) is the live trigger, so WebKit bumps still enable `--jit-stress` correctly — but the `vendor/WebKit/` clause is dead and misleading. Consider dropping it, or add a
Loading