error: read name/message via full [[Get]] for the .stack header; drop inspect.js workaround - #34868
Open
robobun wants to merge 9 commits into
Open
error: read name/message via full [[Get]] for the .stack header; drop inspect.js workaround#34868robobun wants to merge 9 commits into
robobun wants to merge 9 commits into
Claude / Claude Code Review
completed
Jul 21, 2026 in 15m 35s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/util/node-inspect-tests/parallel/util-inspect.test.js:594 |
Sibling '//! temp bug workaround' in util-format.test.js not restored |
Annotations
Check warning on line 594 in test/js/node/util/node-inspect-tests/parallel/util-inspect.test.js
claude / Claude Code Review
Sibling '//! temp bug workaround' in util-format.test.js not restored
There's a sibling `//! temp bug workaround` for the same native stack-header bug at `test/js/node/util/node-inspect-tests/parallel/util-format.test.js:436` — `customError.stack.replace(/^Error/, "Custom$&")` — that this PR should also restore to the upstream `assert.strictEqual(util.format(customError), customError.stack)`. With the native header now correct, `customError.stack` already begins with `CustomError: bar`, so the anchored `/^Error/` never matches and the `.replace()` is a dead no-op;
Loading