-
Notifications
You must be signed in to change notification settings - Fork 5k
bun test: drain the event loop for script files with no test() registrations #34862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
15
commits into
main
Choose a base branch
from
claude/farm/14b6b439/test-drain-script-files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
26a6bd6
bun test: drain the event loop for script files with no test() regist…
robobun 80cdf80
Scope the script-file drain to handles created by that file
robobun 53ab9e4
[autofix.ci] apply automated fixes
autofix-ci[bot] 5202440
Trim new comments to three lines
robobun 39c86cc
Only drain when the loop was idle after preloads
robobun a0f3e3a
[autofix.ci] apply automated fixes
autofix-ci[bot] 40ebbbf
test: make the no-drain regression guards deterministic on Windows
robobun 40a7e62
test: drop explanatory comments from the no-drain guards
robobun 2c76198
Gate the drain on bare hook scopes and bound it by the test timeout
robobun 135b431
[autofix.ci] apply automated fixes
autofix-ci[bot] d9f6cde
Honour default_timeout_override and treat 0 as unlimited for the drai…
robobun b09c346
Merge branch 'main' into claude/farm/14b6b439/test-drain-script-files
robobun ba9c4eb
bun test: bound the script-file drain with the file's own timer and s…
robobun 66f2205
Trim the new doc comments and leave the drain env-var comment where i…
robobun f059c0c
Shorten the remaining new doc comments to one line
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.