win: high-resolution event-loop timer via waitable timer + IOCP - #34834
Merged
Claude / Claude Code Review
completed
Jul 20, 2026 in 15m 31s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | patches/libuv/win-hrtimer.patch:179 |
Accidental revert of explicit timeout bounds from commit 6a019a0 |
Annotations
Check warning on line 179 in patches/libuv/win-hrtimer.patch
claude / Claude Code Review
Accidental revert of explicit timeout bounds from commit 6a019a06
Commit 2757b1fd ("drop process-level probe") accidentally reverted the explicit-bounds change from 6a019a06 — this line is back to `timeout - 1 < 100` instead of `timeout > 0 && timeout <= 100`. Since `timeout` is `DWORD` the two are semantically identical (0−1 wraps to UINT_MAX, INFINITE−1 stays huge), so there's zero runtime effect, but you presumably want the explicit form restored since you dedicated a whole commit to it.
Loading