Treat two Invalid Dates as equal in deepEquals and fix their failure-message rendering - #34819
Open
robobun wants to merge 5 commits into
Open
Treat two Invalid Dates as equal in deepEquals and fix their failure-message rendering#34819robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Jul 20, 2026 in 7m 35s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/test/expect-invalid-date-message.test.ts:24 |
Subprocess test pipes stdout but never drains it |
Annotations
Check warning on line 24 in test/js/bun/test/expect-invalid-date-message.test.ts
claude / Claude Code Review
Subprocess test pipes stdout but never drains it
`stdout: "pipe"` is set on line 21 but the `Promise.all` on line 24 never drains `proc.stdout` — per the harness convention (REVIEW.md "Subprocess tests: drain pipes concurrently"), an unread pipe can fill the OS buffer and wedge the child. Since stdout isn't asserted on, either drop `stdout: "pipe"` or add `proc.stdout.text()` to the `Promise.all`.
Loading