-
Notifications
You must be signed in to change notification settings - Fork 5k
windows: recognize reserved DOS device names before NtCreateFile #34770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
21
commits into
main
Choose a base branch
from
farm/620f5a19/windows-dos-device-names
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+419
−102
Open
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ede3e2c
windows: recognize reserved DOS device names and strip trailing dots/…
robobun d82ede4
fix test cleanup
robobun 0aee1f5
[autofix.ci] apply automated fixes
autofix-ci[bot] 4c9b3b2
exempt UNC, \\.\, \\?\UNC and \??\ paths from DOS device translation
robobun 32c16fb
[autofix.ci] apply automated fixes
autofix-ci[bot] 91e448c
emit \??\ for \\.\ inputs on the NT path; fix unit test assertions; r…
robobun a58ae23
[autofix.ci] apply automated fixes
autofix-ci[bot] 30c0fd1
bundler: strip trailing dot from rendered output paths so an empty [e…
robobun abffb95
take FD_TEST_LOCK in the new normalize_path_windows unit tests
robobun 30981ef
use comptime_string_map for the reserved DOS device name table
robobun 4922b21
doc: cite RtlIsDosDeviceName_U / MS naming rules for the reserved-nam…
robobun 95649a4
simplify the trailing-trim in windows_reserved_device_name_t
robobun 768f14c
test.concurrent for the device-name suite; strip trailing space from …
robobun ff1f852
[autofix.ci] apply automated fixes
autofix-ci[bot] 2b44001
remove now-dead \\.\ -> CreateFileW fallback from open_dir_at_windows…
robobun c485fe9
trim comments to three lines
robobun 44a349e
drop the trailing-dot/space strip (regresses drive-absolute write/sta…
robobun 7a6d51d
trim remaining comment blocks in normalize_path_windows_opts to three…
robobun f9472a9
drop the stale 'and our NT open path' clause from the bundler trim co…
robobun 53a19fb
revert bundler trailing-dot trim (no longer needed now the normalize …
robobun de663fc
trim test file header comment to three lines
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.