process: execArgv fix, getActiveResourcesInfo with sockets/servers/fs, _getActiveHandles/_getActiveRequests (+9 tests, process 85%→94%) - #34658
Open
cirospaciari wants to merge 108 commits into
Open
Claude / Claude Code Review
completed
Aug 7, 2026 in 44m 45s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/js/internal/active_handles.ts:75 |
Non-intrinsic Array .push() alongside tamper-proofed Map intrinsics |
Annotations
Check warning on line 75 in src/js/internal/active_handles.ts
claude / Claude Code Review
Non-intrinsic Array .push() alongside tamper-proofed Map intrinsics
The seven plain `.push()` calls (`out.push` at :75, `resources.push` at :92/:95/:99/:102, `requests.push` at :112/:115) sit next to the `.$set`/`.$delete`/`.$forEach` intrinsics a7ed4a2 added to this same file, so a tampered `Array.prototype.push` still runs during `_getActiveHandles()`/`getActiveResourcesInfo()`. `$arrayPush(arr, item)` is the in-tree intrinsic (builtins.d.ts:89, used in child_process.ts / diagnostics_channel.ts / BundlerPlugin.ts) and Node's per_thread.js equivalent uses `Arra
Loading