diagnostics_channel: vendor the two http channel tests (+2) - #34641
Merged
cirospaciari merged 6 commits intoJul 23, 2026
Merged
Claude / Claude Code Review
completed
Jul 20, 2026 in 12m 4s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/expectations.txt:182-185 |
DARWIN quarantine of no-orphans.test.ts drops ~15 tests' coverage for one flaky case |
Annotations
Check warning on line 185 in test/expectations.txt
claude / Claude Code Review
DARWIN quarantine of no-orphans.test.ts drops ~15 tests' coverage for one flaky case
The `[ DARWIN ] test/cli/run/no-orphans.test.ts [ FLAKY ]` entry drops all 16 `test.concurrent` cases from macOS CI, but the comment describes one identifiable case flaking ~1 retry each — `fast-exit intermediate (no pidfile spin)` at no-orphans.test.ts:449. Per this file's own header (lines 11-15: "If a single test is broken, skip THAT test in the file… Reserve this file for a file that cannot be run at all"), the targeted fix is `test.concurrent.todoIf(process.platform === 'darwin')` on that o
Loading