diagnostics_channel: vendor the two http channel tests (+2) - #34641
Merged
cirospaciari merged 6 commits intoJul 23, 2026
Merged
Claude / Claude Code Review
completed
Jul 20, 2026 in 16m 58s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/test/parallel/test-diagnostics-channel-http.js:75-80 |
Test performs real external DNS lookup without mock (potential hang on NXDOMAIN-hijacking resolvers) |
Annotations
Check warning on line 80 in test/js/node/test/parallel/test-diagnostics-channel-http.js
claude / Claude Code Review
Test performs real external DNS lookup without mock (potential hang on NXDOMAIN-hijacking resolvers)
This is the first file in `test/js/node/test/parallel/` to perform a real DNS lookup — `http.get({ host: addresses.INVALID_HOST })` calls getaddrinfo() for `something.invalid` with no `lookup:` mock (the four pre-existing files here that import `common/internet` all pass `errorLookupMock()` or use the constant only as a string). On a resolver that hijacks NXDOMAIN (captive portal / ISP redirect), `.invalid` resolves to a real IP and the `await new Promise(resolve => invalidRequest.on('error', re
Loading