jsc: treat DFG Plan::m_mustHandleValues as weak so queued compiles don't root user objects - #34640
Open
robobun wants to merge 6 commits into
Open
jsc: treat DFG Plan::m_mustHandleValues as weak so queued compiles don't root user objects#34640robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jul 18, 2026 in 7m 57s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/jsc/bun-jsc.test.ts:587 |
New subprocess test asserts stderr is exactly empty |
Annotations
Check warning on line 587 in test/js/bun/jsc/bun-jsc.test.ts
claude / Claude Code Review
New subprocess test asserts stderr is exactly empty
REVIEW.md's Subprocess-tests section says never to assert stderr is exactly empty because ASAN/debug builds emit benign warnings — and this test explicitly runs under ASAN (it extends the timeout for it). A benign ASAN warning would fail here before the load-bearing `jitworklist-rooted=0` assertion is reached. The three most-recently-added tests in this file (lines ~490, ~522, ~555) already drop the stderr-empty check; this one can do the same (stderr is already drained by the `Promise.all`, so
Loading