Bun.serve: cap chunk-extension bytes at 16 KiB per chunk - #34504
Merged
Claude / Claude Code Review
completed
Jul 17, 2026 in 14m 4s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/bun-uws/src/HttpParser.h:576-578 |
Stale 'node:http compat only' comment on HTTP_PARSER_ERROR_CHUNK_EXTENSIONS_OVERFLOW |
Annotations
Check warning on line 578 in packages/bun-uws/src/HttpParser.h
claude / Claude Code Review
Stale 'node:http compat only' comment on HTTP_PARSER_ERROR_CHUNK_EXTENSIONS_OVERFLOW
The sibling doc comment on `HTTP_PARSER_ERROR_CHUNK_EXTENSIONS_OVERFLOW` (HttpParser.h:~90) still says "node:http compat only", but this PR removes the `IsNodeHttp` gate so Bun.serve now returns that error too. Worth updating in the same PR to keep it consistent with this comment.
Loading