usockets(tls): FIN the TCP write side after SSL_shutdown completes on a half-open socket - #34498
Merged
Merged
Claude / Claude Code Review
completed
Jul 17, 2026 in 13m 0s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/http/node-http-connect.test.ts:558-571 |
Test comment blocks exceed 3-line max and contain bug history |
Annotations
Check warning on line 571 in test/js/node/http/node-http-connect.test.ts
claude / Claude Code Review
Test comment blocks exceed 3-line max and contain bug history
Nit: the 7-line comment at 558–564 and the 4-line block at 568–571 exceed CLAUDE.md's 3-line comment cap, and 558–564 is largely bug history ("previously returned without the raw TCP shutdown, so the poll type never moved to SHUT_DOWN…") that REVIEW.md says belongs in the PR description — where it already lives verbatim. Consider trimming 558–564 to just the Linux-only `skipIf` justification and condensing 568–571 to ≤3 lines on why `tls.connect({socket: raw})` is deliberately used; the pre-fix
Loading