WebKit: use GetSystemTimePreciseAsFileTime for WallTime and QPC for MonotonicTime on Windows - #34428
Open
robobun wants to merge 8 commits into
Open
WebKit: use GetSystemTimePreciseAsFileTime for WallTime and QPC for MonotonicTime on Windows#34428robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Jul 17, 2026 in 16m 41s
Code review found 2 important issues
Found 1 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 2 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | scripts/build/deps/webkit.ts:10 |
WEBKIT_VERSION points at an ephemeral preview tag |
Annotations
Check failure on line 10 in scripts/build/deps/webkit.ts
claude / Claude Code Review
WEBKIT_VERSION points at an ephemeral preview tag
`WEBKIT_VERSION` points at `autobuild-preview-pr-304-36986ac9`, an ephemeral tag that is deleted once oven-sh/WebKit#304 merges/closes — landing this as-is would 404 every fresh prebuilt WebKit download and permanently break `git bisect` across this commit. As the PR description already notes, swap this to the merged oven-sh/WebKit main sha (40-hex) before landing; filing as a blocking review item so it isn't merged by accident.
Loading