node:worker_threads: per-thread --use-system-ca, real eventLoopUtilization, --cpu-prof in workers, node's online timing, error.code / stack-getter / timeOrigin fixes, async_hooks WORKER resource, worker_threads dc channel (+10 upstream tests) - #34424
Open
cirospaciari wants to merge 80 commits into
Claude / Claude Code Review
completed
Jul 17, 2026 in 17m 2s
Code review found 1 important issue
Found 1 candidates, confirmed 5. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 4 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/webcore/JSBroadcastChannel.cpp:390-392 |
BroadcastChannel ref() return-value change ships without a test |
Annotations
Check warning on line 392 in src/jsc/bindings/webcore/JSBroadcastChannel.cpp
claude / Claude Code Review
BroadcastChannel ref() return-value change ships without a test
nit: `BroadcastChannel#ref()` now returns `this` (a behavioral change) but no test asserts on it — commit c308af4b touches only `JSBroadcastChannel.cpp`, and the commit message cites manual verification against node v26.3.0. Per REVIEW.md ("Every behavioral change ships an automated test in the same PR … 'Verified manually' doesn't count, even for one-liners"), a one-liner in `test/js/web/broadcastchannel/broadcast-channel.test.ts` would guard this against a bindings-regeneration silently revert
Loading