Skip to content

serve: trace every server-level callback from the JS wrapper instead of rooting them as Strong - #34346

Merged
Jarred-Sumner merged 21 commits into
mainfrom
claude/farm/ebef6d1a/server-strong-callbacks-to-cached-values
Jul 18, 2026
Merged

serve: trace every server-level callback from the JS wrapper instead of rooting them as Strong#34346
Jarred-Sumner merged 21 commits into
mainfrom
claude/farm/ebef6d1a/server-strong-callbacks-to-cached-values

server: store node:http onClientError/onConnection as cached JS value…

fb45958
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 16, 2026 in 11m 50s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/runtime/server/mod.rs:2960-2972 Module name route_list_cached is now misleading

Annotations

Check warning on line 2972 in src/runtime/server/mod.rs

See this annotation in the file changed.

@claude claude / Claude Code Review

Module name route_list_cached is now misleading 

Nit: the `route_list_cached` module now holds cached-accessor shims for three slots (`routeList`, `onClientError`, `onConnection`), so the identifier no longer matches its contents — paths like `route_list_cached::http::on_client_error_get_cached` read oddly. The doc comment was updated but the name wasn't; consider renaming to something like `cached_slots` or `server_cached_values` per CLAUDE.md's "Name things truthfully" guidance. Cosmetic only.
View more details on Claude