redis: raise the RESP line-length cap from 512KB to 512MB - #34312
Merged
Claude / Claude Code Review
completed
Jul 16, 2026 in 13m 53s
Code review found 1 potential issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/valkey/valkey-gc.test.ts:135-138 |
Stale test comments after MAX_LINE_LEN was reintroduced at 512MB |
Annotations
Check warning on line 138 in test/js/valkey/valkey-gc.test.ts
claude / Claude Code Review
Stale test comments after MAX_LINE_LEN was reintroduced at 512MB
This comment ("The reader imposes no length cap on the line") was accurate for intermediate commit c30f2307, but follow-up 0f809817 reintroduced `MAX_LINE_LEN` at `MAX_BULK_LEN` (512 MB) — the source now explicitly documents it as a buffer-growth bound (`src/valkey/valkey_protocol.rs:346-349`), so the prose here contradicts the code it describes. The same follow-up also left a sibling reference stale at `test/js/valkey/valkey-incremental-scan.test.ts:130-132`, which still cites "the protocol's 5
Loading