Skip to content

parser: apply ASI when TS contextual keywords precede a newline - #34258

Merged
dylan-conway merged 11 commits into
mainfrom
farm/80275baa/ts-contextual-keyword-asi
Jul 15, 2026
Merged

parser: apply ASI when TS contextual keywords precede a newline#34258
dylan-conway merged 11 commits into
mainfrom
farm/80275baa/ts-contextual-keyword-asi

test(scope-mismatch-panic): resolve react from test/node_modules expl…

bb9014b
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 15, 2026 in 15m 3s

Code review found 1 potential issue

Found 2 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/js_parser/parse/parse_stmt.rs:1863-1866 New comment exceeds CLAUDE.md 3-line max

Annotations

Check warning on line 1866 in src/js_parser/parse/parse_stmt.rs

See this annotation in the file changed.

@claude claude / Claude Code Review

New comment exceeds CLAUDE.md 3-line max

nit: this new comment is 4 lines, one over CLAUDE.md rule 13's 3-line max. Easily tightened — e.g. drop the parenthetical example list (already covered by the tests) or merge the last two lines into `// esbuild rewinds its lexer here; we point at the range captured before recursing instead.`