Stop inlining process.env dot-reads in Worker-thread transpiles - #34211
Open
robobun wants to merge 5 commits into
Open
Stop inlining process.env dot-reads in Worker-thread transpiles#34211robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Jul 25, 2026 in 16m 16s
Code review found 1 important issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/jsc/web_worker.rs:979-981 |
Poisoned transpiler-cache entries survive upgrade: EXPECTED_VERSION not bumped |
Annotations
Check failure on line 981 in src/jsc/web_worker.rs
claude / Claude Code Review
Poisoned transpiler-cache entries survive upgrade: EXPECTED_VERSION not bumped
This stops workers from *writing* env-inlined cache entries, but poisoned `.pile` entries already on disk are still accepted after upgrade — the cache key is `(input_hash, features_hash, EXPECTED_VERSION)`, none of which change with `env.behavior`, and `EXPECTED_VERSION` stays at 23. A user who hit #34210 will keep seeing the stale value until they manually `rm -rf ~/.bun/install/cache/@t@`. Bump `EXPECTED_VERSION` to 24 in `src/jsc/RuntimeTranspilerCache.rs` with a history entry citing #34210 (
Loading