Skip to content

test(require-cache): gate the long-export-names import() leak fixture on mimalloc page growth #34159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test(require-cache): gate the long-export-names import() leak fixture on mimalloc page growth #34159

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f00c69c
test(require-cache): sample RSS over mimalloc's idle sweep window
robobun Jul 14, 2026
497603e
Drop the sleep; match warmup to the measured round instead
robobun Jul 19, 2026
7cd128a
Gate on mimalloc live-page growth instead of RSS
robobun Jul 19, 2026
92d4661
Keep the RSS bound under ASAN
robobun Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions test/cli/run/require-cache.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,30 +168,38 @@ describe.concurrent("require.cache", () => {
const dir = tempDirWithFiles("require-cache-bug-leak-4", {
"index.js": text,
"require-cache-bug-leak-fixture.js": `
import { heapStats } from "bun:jsc";
const path = require.resolve("./index.js");
const gc = global.gc || globalThis?.Bun?.gc || (() => {});
function bust() {
delete require.cache[path];
}
// Live page count from the heap walk (not the aggregate counter,
// which can under-count across threads).
function livePages() {
let n = 0;
for (const h of heapStats({ dump: true }).mimallocDump.heaps) n += h.pages.length;
return n;
}

for (let i = 0; i < 50; i++) {
await import(path);
bust();
}
gc(true);
const baseline = process.memoryUsage.rss();
const baselinePages = livePages();
const baselineRss = process.memoryUsage.rss();
for (let i = 0; i < 250; i++) {
await import(path);
bust(path);
}
gc(true);
const rss = process.memoryUsage.rss();
const diff = rss - baseline;
console.log("RSS diff", (diff / 1024 / 1024) | 0, "MB");
console.log("RSS", (diff / 1024 / 1024) | 0, "MB");
if (diff > ${isASAN ? 320 : 64} * 1024 * 1024) {
// Bun v1.1.21 reported 423 MB here on macoS arm64.
// Bun v1.1.22 reported 4 MB here on macoS arm64.
const pageDiff = livePages() - baselinePages;
const rssDiff = process.memoryUsage.rss() - baselineRss;
console.log("mimalloc page diff", pageDiff, "RSS diff", (rssDiff / 1024 / 1024) | 0, "MB");
// ASAN routes SourceProvider storage through system malloc, so fall
// back to RSS there. Retaining the source is ~+290 MB / +2666 pages.
if (${isASAN} ? rssDiff > 320 * 1024 * 1024 : pageDiff > 100) {
throw new Error("Memory leak detected");
}

Expand Down
Loading