cli: declare Node's value-taking flags so their value is not parsed as the entrypoint - #34100
Open
robobun wants to merge 3 commits into
Open
cli: declare Node's value-taking flags so their value is not parsed as the entrypoint#34100robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Jul 14, 2026 in 19m 0s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/cli/Arguments.rs:362-378 |
--test-name-pattern omitted from value-taking Node flag list |
Annotations
Check warning on line 378 in src/runtime/cli/Arguments.rs
claude / Claude Code Review
--test-name-pattern omitted from value-taking Node flag list
`--test-name-pattern` is also a value-taking option in Node's `node_options.cc` (StringVector `test_name_pattern`) but is missing from this list — it's declared only in `TEST_ONLY_PARAMS`, which doesn't feed `AUTO_PARAMS`/`RUN_PARAMS`/run-as-node. So `bun --test-name-pattern foo app.mjs` still parses `foo` as the entrypoint. Note that naively adding it here would collide with the existing `TEST_ONLY_PARAMS` entry in `TEST_PARAMS`, so the fix may need to move/dedupe that declaration.
Loading