Skip to content

Rewrite the uSockets core in Rust - #34037

Open
Jarred-Sumner wants to merge 45 commits into
mainfrom
claude/usockets-rust-rewrite
Open

Rewrite the uSockets core in Rust#34037
Jarred-Sumner wants to merge 45 commits into
mainfrom
claude/usockets-rust-rewrite

update dead-code escape inventory for the two platform-split allows

b061f12
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 13, 2026 in 23m 27s

Code review found 7 potential issues

Found 1 candidates, confirmed 7. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 7
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit Cargo.toml:90 src/usockets/Cargo.toml references gitignored .rewrite-specs/ working notes

Annotations

Check warning on line 90 in Cargo.toml

See this annotation in the file changed.

@claude claude / Claude Code Review

src/usockets/Cargo.toml references gitignored .rewrite-specs/ working notes 

🟡 Companion to still-open #19 (`src/bssl/bindings/README.md` → `.rewrite-specs/tls-semantics.md`): three more gitignored working-notes references at `src/usockets/Cargo.toml` — line 26 `(protocol.rs; safe-protocol.md)`, line 28 `(consumers/04)`, line 31 `(tls-semantics.md Part 2d)`. None exist in-tree (`src/usockets/docs/` has only `cabi.md`/`design.md`/`semantics.md`/`tls.md`; `.rewrite-specs/` is gitignored by this PR at `.gitignore:219`), and two of the three (`safe-protocol.md`, `consumers/0
View more details on Claude