Rewrite the uSockets core in Rust - #34037
Open
Jarred-Sumner wants to merge 45 commits into
Open
Claude / Claude Code Review
completed
Jul 13, 2026 in 19m 27s
Code review found 3 potential issues
Found 1 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | Cargo.toml:89 |
find_ctx doc says 'Exact-pattern' but impl (correctly) does wildcard fallback per C-parity; CodeRabbit fix would regress |
Annotations
Check warning on line 89 in Cargo.toml
claude / Claude Code Review
find_ctx doc says 'Exact-pattern' but impl (correctly) does wildcard fallback per C-parity; CodeRabbit fix would regress
The doc comments at `src/usockets/tls/sni.rs:164` ("Exact-pattern lookup") and `src/usockets/unsafe_core/ffi.rs:714` ("exact-pattern SNI lookup") are wrong — `find_ctx()` → `lookup()` → `get()` falls back to `*` children (sni.rs:107), which is wildcard-aware and matches the deleted C (`sni_find` → `getUser`). The unresolved CodeRabbit comment at sni.rs:161 suggests the opposite fix (change the impl to exact-match), but that would regress `App.h onMissingServerName` — which passes the concrete ne
Loading