webstreams: make Blob/File/body streams byte streams so BYOB readers attach - #33927
Closed
robobun wants to merge 11 commits into
Closed
webstreams: make Blob/File/body streams byte streams so BYOB readers attach#33927robobun wants to merge 11 commits into
robobun wants to merge 11 commits into
Claude / Claude Code Review
completed
Jul 10, 2026 in 24m 28s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/webcore/streams/JSReadableStreamDefaultController.cpp:106-107 |
Stale reachable-kind comment in default controller pull/cancel dispatch |
Annotations
Check warning on line 107 in src/jsc/bindings/webcore/streams/JSReadableStreamDefaultController.cpp
claude / Claude Code Review
Stale reachable-kind comment in default controller pull/cancel dispatch
The comment above `performDefaultControllerPullAlgorithm` (line 56) explains why `ByteTeeBranch` and `CrossRealm` fall through to `RELEASE_ASSERT_NOT_REACHED()`, but this PR moves `SourceKind::Native` into that same fall-through group without adding it to the enumeration. This is the mirror of the `JSReadableByteStreamController.cpp` comment that was updated in 7f8af8b333 — a one-phrase edit ("Native and ByteTeeBranch are byte-controller-only") would resync it. Documentation-only, no runtime eff
Loading