Replace bun_core::Error intern machinery with per-crate thiserror enums

src/CLAUDE.md

@@ -17,7 +17,7 @@ Conventions:
 - `cargo check -p <crate>` for fast iteration; `bun bd` builds and links everything.
 - Don't `.unwrap()` a fallible path that user input or the OS can hit at runtime — return the error. `.unwrap()` is for invariants you can prove.
 - The C ABI / syscall boundary uses `bun_sys::Maybe<T>` (= `Result<T, bun_sys::Error>`); ordinary Rust code uses `Result<T, E>` with `?`.
-- `bun_core::Error` is a lightweight interned `NonZeroU16` error code; `bun_sys::Error` is the rich syscall error (errno + syscall tag + path). `From<bun_sys::Error> for bun_core::Error` exists.
+- Each crate defines its own `Error` enum (a `thiserror::Error` at `<crate>/error.rs`, re-exported as `crate::Error` + `crate::Result`). Errno codes nest via `Sys(#[from] bun_errno::SystemErrno)`; OOM via `Alloc(#[from] bun_alloc::AllocError)`. `bun_sys::Error` is the rich syscall error (errno + syscall tag + path); `From<bun_sys::Error> for bun_errno::SystemErrno` exists for `?`-chaining.
 - NEVER add comments to deleted code blocks.
 - Do not add comments that reference context from the transcript.
 - Avoid adding comments where not necessary.

src/analytics/Cargo.toml

@@ -21,3 +21,5 @@ bitflags.workspace = true
 bun_core.workspace = true
 bun_semver.workspace = true
 bun_sys.workspace = true
+thiserror.workspace = true
+bun_errno.workspace = true

src/analytics/error.rs

@@ -0,0 +1,29 @@
+#[derive(Debug, Clone, Copy, PartialEq, Eq, thiserror::Error)]
+pub enum Error {
+    #[error("Unexpected")]
+    Unexpected,
+    #[error("EOF")]
+    EOF,
+
+    #[error(transparent)]
+    Sys(#[from] bun_errno::SystemErrno),
+}
+
+impl Error {
+    #[allow(clippy::trivially_copy_pass_by_ref)]
+    pub fn name(&self) -> &'static str {
+        match self {
+            Self::Sys(e) => <&'static str>::from(e),
+            Self::Unexpected => "Unexpected",
+            Self::EOF => "EOF",
+        }
+    }
+}
+
+impl bun_core::output::ErrName for Error {
+    fn name(&self) -> &[u8] {
+        (*self).name().as_bytes()
+    }
+}
+
+pub type Result<T, E = Error> = core::result::Result<T, E>;

src/analytics/lib.rs

@@ -601,3 +601,6 @@ pub use generate_header as GenerateHeader;
 
 pub mod schema;
 pub use schema::{BufReader, Reader, SchemaInt};
+
+pub mod error;
+pub use error::{Error, Result};