Skip to content

install: never delete a concurrently published cache entry on Windows #33884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jarred-Sumner wants to merge 5 commits into
base: main
Choose a base branch
from
+176 −41
Open

install: never delete a concurrently published cache entry on Windows #33884

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6b5e63
install: never delete a concurrently published cache entry on Windows
Jarred-Sumner Jul 10, 2026
3b5cf84
install(windows): keep stale-cache eviction, add concurrent publish r…
robobun Aug 2, 2026
7310b81
[autofix.ci] apply automated fixes
autofix-ci[bot] Aug 2, 2026
8353d5b
install(windows): evict stale cache entry by handle, mirror package_m…
robobun Aug 2, 2026
45ed0f6
test(28062): skip verdaccio fork on non-Windows, raise beforeAll timeout
robobun Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 22 additions & 49 deletions src/install/extract_tarball.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,59 +573,32 @@ impl ExtractTarball {
true,
) {
bun_sys::Result::Err(err) => {
if retries < MAX_RETRIES {
match err.get_errno() {
sys::Errno::NOTEMPTY
let _ = sys::close(dir_to_move);
if matches!(
err.get_errno(),
sys::Errno::NOTEMPTY
| sys::Errno::PERM
| sys::Errno::BUSY
| sys::Errno::EXIST => {
// before we attempt to delete the destination, let's close the source dir.
let _ = sys::close(dir_to_move);

// We tried to move the folder over
// but it didn't work!
// so instead of just simply deleting the folder
// we rename it back into the temp dir
// and then delete that temp dir
// The goal is to make it more difficult for an application to reach this folder
let mut tempdest_buf = PathBuffer::uninit();
tempdest_buf[0..tmpname.len()]
.copy_from_slice(tmpname.as_bytes());
tempdest_buf[tmpname.len()..][0..4]
.copy_from_slice(&[b't', b'm', b'p', 0]);
let tempdest =
ZStr::from_buf(&tempdest_buf, tmpname.len() + 3);
let mut folder_name_z_buf = PathBuffer::uninit();
folder_name_z_buf[0..folder_name.len()]
.copy_from_slice(folder_name);
folder_name_z_buf[folder_name.len()] = 0;
let folder_name_z =
ZStr::from_buf(&folder_name_z_buf, folder_name.len());
match sys::renameat(
Fd::from_std_dir(cache_dir),
folder_name_z,
Fd::from_std_dir(tmpdir),
tempdest,
) {
bun_sys::Result::Err(_) => {}
bun_sys::Result::Ok(_) => {
let _ = tmpdir.delete_tree(tempdest.as_bytes());
}
}
retries += 1;
// 10ms, 20ms, 40ms, 80ms — long enough
// for a concurrent close to land,
// short enough to not slow a legit
// failure noticeably.
std::thread::sleep(std::time::Duration::from_millis(
10u64 << (retries - 1),
));
continue;
}
_ => {}
| sys::Errno::EXIST
) {
// The cache path is keyed by the package identity, so an existing
// destination is an equivalent entry that a concurrent `bun install`
// published first. Never delete it — accept it and drop our copy.
if cache_dir.open_at(folder_name).is_ok() {
let _ = tmpdir.delete_tree(tmpname.as_bytes());
break;
}
if retries < MAX_RETRIES {
retries += 1;
// 10ms, 20ms, 40ms, 80ms — long enough for a
// concurrent close to land, short enough to not
// slow a legitimate failure noticeably.
std::thread::sleep(std::time::Duration::from_millis(
10u64 << (retries - 1),
));
continue;
}
}
let _ = sys::close(dir_to_move);
log.add_error_fmt(
None,
bun_ast::Loc::EMPTY,
Expand Down
Loading