Update TinyCC to latest upstream - #33653
Closed
Jarred-Sumner wants to merge 1 commit into
Closed
Claude / Claude Code Review
completed
Jul 7, 2026 in 20m 19s
Code review found 1 important issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | scripts/build/deps/tinycc.ts:5-6 |
Windows ARM64 enablement claimed in title/description but absent from the diff |
Annotations
Check failure on line 6 in scripts/build/deps/tinycc.ts
claude / Claude Code Review
Windows ARM64 enablement claimed in title/description but absent from the diff
The PR title, description (section 2), and the 18:37 follow-up comment all say this push enables `bun:ffi` on Windows ARM64, but that commit isn't in the diff — only 4 files are touched, `config.ts:869` still gates tinycc off for `(windows && arm64)`, `cc.test.ts:8` still sets `isFFIUnavailable = isWindows && isArm64`, and this very comment is being *updated* to say "Disabled on windows-arm64 … bun:ffi has never been enabled there". Looks like the second commit was never pushed (or got dropped)
Loading