event loop: run the timers phase before the entry point's queued work - #33509
Open
robobun wants to merge 13 commits into
Open
event loop: run the timers phase before the entry point's queued work#33509robobun wants to merge 13 commits into
robobun wants to merge 13 commits into
Claude / Claude Code Review
completed
Jul 6, 2026 in 22m 44s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/VirtualMachine.rs:2454-2474 |
d85c448 reverted the rejection-ordering guards; PR description and resolved threads are stale |
Annotations
Check warning on line 2474 in src/jsc/VirtualMachine.rs
claude / Claude Code Review
d85c4483 reverted the rejection-ordering guards; PR description and resolved threads are stale
d85c4483 dropped the `handle_rejected_promises()` call, the `unhandled_error_counter` snapshot/guard, and the second `drain_microtasks()` from `run_entry_point_body` (its commit message says the proactive call "broke test-event-capture-rejections" and "Timer-vs-rejection ordering is no longer claimed"), and deleted the three tests covering it — but the PR description still says "unhandled rejections are notified first", "it is snapshotted on entry rather than compared against zero", and lists th
Loading