Set has_loaded on every path that produces the entry point's source - #33371
Merged
Claude / Claude Code Review
completed
Aug 13, 2026 in 12m 33s
Code review found 1 important issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | test/cli/run/transpiler-cache.test.ts:272-278 |
New transpiler-cache tests do not await async bunRun() |
Annotations
Check failure on line 278 in test/cli/run/transpiler-cache.test.ts
claude / Claude Code Review
New transpiler-cache tests do not await async bunRun()
The two new tests call `bunRun()` without `await` inside non-async callbacks, but `bunRun` in `test/harness.ts` is now `async` (converted in 8d10147f on 2026-08-11, pulled in by the merge commit). `a` and `b` are Promises, so `a.stdout` is `undefined` and `expect(undefined).toBe("custom-loader")` fails on the first assertion — both new regression tests are dead-on-arrival on the merged branch. Make both `test(...)` callbacks `async` and `await` all four `bunRun(...)` calls (lines 272, 276, 290,
Loading