Skip to content

ffi: toArrayBuffer/toBuffer throw RangeError instead of aborting on a huge byteLength #33353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 2 commits into
base: main
Choose a base branch
from
+265 −148
Open

ffi: toArrayBuffer/toBuffer throw RangeError instead of aborting on a huge byteLength #33353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed13026
ffi: toArrayBuffer/toBuffer throw RangeError instead of aborting on a…
robobun Jul 5, 2026
75bc1fc
ffi: accept an omitted byteOffset, reject a non-number one
robobun Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/jsc/array_buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use core::ffi::{c_uint, c_void};
use core::ffi::c_void;
use core::ptr;

use crate as jsc;
Expand Down Expand Up @@ -155,9 +155,10 @@ impl ArrayBuffer {
self.value.unpin_array_buffer();
}

// require('buffer').kMaxLength.
// The largest byte length JavaScriptCore backs an ArrayBuffer with
// (`MAX_ARRAY_BUFFER_SIZE`), exposed to JS as `require('buffer').kMaxLength`.
// keep in sync with Bun::Buffer::kMaxLength
pub const MAX_SIZE: c_uint = c_uint::MAX;
pub const MAX_SIZE: usize = 1 << 32;

// 4 MB or so is pretty good for mmap()
const MMAP_THRESHOLD: usize = 1024 * 1024 * 4;
Expand Down Expand Up @@ -424,8 +425,8 @@ impl ArrayBuffer {

pub fn from_bytes(bytes: &mut [u8], typed_array_type: JSType) -> ArrayBuffer {
ArrayBuffer {
len: u32::try_from(bytes.len()).expect("int cast") as usize,
byte_len: u32::try_from(bytes.len()).expect("int cast") as usize,
len: bytes.len(),
byte_len: bytes.len(),
typed_array_type,
ptr: bytes.as_mut_ptr(),
..Default::default()
Expand All @@ -446,8 +447,8 @@ impl ArrayBuffer {
// this is an FFI hand-off, not a leak.
let ptr = bun_core::heap::into_raw(bytes).cast::<u8>();
ArrayBuffer {
len: u32::try_from(len).expect("int cast") as usize,
byte_len: u32::try_from(len).expect("int cast") as usize,
len,
byte_len: len,
typed_array_type,
ptr,
..Default::default()
Expand Down
Loading
Loading