HTMLRewriter: accept a Response whose body is a JS-created ReadableStream - #33310
Closed
robobun wants to merge 6 commits into
Closed
HTMLRewriter: accept a Response whose body is a JS-created ReadableStream#33310robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jul 15, 2026 in 15m 8s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/webcore/Body.rs:2546-2549 |
Dead enum variant: crate::Error::UnsupportedStreamType |
Annotations
Check warning on line 2549 in src/runtime/webcore/Body.rs
claude / Claude Code Review
Dead enum variant: crate::Error::UnsupportedStreamType
nit: This PR removes the only construction site of `crate::Error::UnsupportedStreamType` (the `Source::JavaScript | Source::Direct` arm now calls `buffer_js_readable_stream` instead of returning it). The variant and its string-mapping arm in `src/runtime/error.rs` are now dead and should be deleted here alongside the other dead-code cleanups (`js_sink`, `ArrayBufferJSSink`) this PR already performs.
Loading