fs.watch(macOS): make FSEventsLoop Sync and retain the CFRunLoop across shutdown - #33303
Merged
Merged
Claude / Claude Code Review
completed
Jul 4, 2026 in 11m 24s
Code review found 3 potential issues
Found 5 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/node/path_watcher.rs:1560-1562 |
Orphaned 'Windows stub' section header after WindowsStub deletion |
Annotations
Check warning on line 1562 in src/runtime/node/path_watcher.rs
claude / Claude Code Review
Orphaned 'Windows stub' section header after WindowsStub deletion
The `WindowsStub` struct + impl were deleted in the final commit, but the three-line "// Windows stub" section-divider banner that introduced them is left behind as the last three lines of the file with nothing beneath it. Trivial cleanup: delete lines 1560-1562. (Related but lower-priority: now that the whole module is `#[cfg(not(windows))]` at `src/runtime/node.rs:96`, the internal `#[cfg(not(windows))]` gates on `ChangeEvent`'s fields/impl and `PathWatcher::emit` are also redundant.)
Loading