bun:jsc: filter internal cells out of getProtectedObjects() - #33183
Open
robobun wants to merge 2 commits into
Open
bun:jsc: filter internal cells out of getProtectedObjects()#33183robobun wants to merge 2 commits into
robobun wants to merge 2 commits into
Claude / Claude Code Review
completed
Jul 11, 2026 in 6m 21s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/modules/BunJSCModule.h:593-599 |
Stale JSDoc warning on getProtectedObjects() type declaration |
Annotations
Check warning on line 599 in src/jsc/modules/BunJSCModule.h
claude / Claude Code Review
Stale JSDoc warning on getProtectedObjects() type declaration
The JSDoc at `packages/bun-types/jsc.d.ts:201` ("Warning: not all of the returned objects are supposed to be observable from JavaScript.") described the pre-fix behavior where internal cells could appear in the array; now that only `JSObject` cells are returned, every element is safely observable and the warning is stale. Consider dropping or rewording that line (and optionally tightening the return type to `object[]`) in this PR so the docs match the new contract.
Loading