Skip to content

Implement Node's deep equality algorithm for node:assert #33068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement Node's deep equality algorithm for node:assert #33068

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
219586c
node:assert: use Node's deep equality algorithm
robobun Jun 29, 2026
bab3430
fix lint, mark node tests unmasked by the stricter comparison as expe…
robobun Jun 29, 2026
8b7436d
quarantine test-net-connect-memleak on linux-x64-musl like its tls si…
robobun Jun 29, 2026
8423cd5
ci: retrigger
robobun Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/js/internal/primordials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ export default {
),
SetPrototypeGetSize: getGetter(Set, "size"),
String,
TypedArrayPrototypeGetByteLength: getGetter(Uint8Array, "byteLength"),
TypedArrayPrototypeGetLength: getGetter(Uint8Array, "length"),
TypedArrayPrototypeGetSymbolToStringTag: getGetter(Uint8Array, Symbol.toStringTag),
Uint8ClampedArray,
Expand Down
Loading
Loading