Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/node/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1636,7 +1636,7 @@ pub fn mode_from_js(ctx: &JSGlobalObject, value: JSValue) -> JsResult<Option<Mod
}
};

Ok(Some((mode_int & 0o777) as Mode))
Ok(Some((mode_int & 0o7777) as Mode))
}

// ──────────────────────────────────────────────────────────────────────────
Expand Down
64 changes: 64 additions & 0 deletions test/js/node/fs/fs.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1733,6 +1733,18 @@ describe("writeFileSync", () => {
const stat = fs.statSync(path);
expect(stat.mode).toBe(isWindows ? 33206 : 33188);
});
it.skipIf(isWindows)("write file preserves special POSIX mode bits", () => {
for (const mode of [0o107644, "107644"] as const) {
const path = `${tmpdirSync()}/writeFileSyncWithSpecialMode.txt`;
const oldUmask = process.umask(0);
try {
writeFileSync(path, "bun", { mode });
} finally {
process.umask(oldUmask);
}
expect(fs.statSync(path).mode & 0o7777).toBe(0o7644);
}
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.
it("returning Buffer works", () => {
const buffer = new Buffer([
70, 105, 108, 101, 32, 119, 114, 105, 116, 116, 101, 110, 32, 115, 117, 99, 99, 101, 115, 115, 102, 117, 108, 108,
Expand Down Expand Up @@ -1761,6 +1773,58 @@ describe("writeFileSync", () => {
});
});

describe.skipIf(isWindows)("chmod", () => {
const specialMode = 0o7644;
const inputMode = 0o100000 | specialMode;
const inputs = [inputMode, inputMode.toString(8)];

it("preserves special POSIX mode bits", async () => {
for (const input of inputs) {
const path = `${tmpdirSync()}/chmodSpecialMode.txt`;
writeFileSync(path, "bun");

fs.chmodSync(path, input);
expect(fs.statSync(path).mode & 0o7777).toBe(specialMode);

await new Promise<void>((resolve, reject) => {
fs.chmod(path, input, err => {
if (err) reject(err);
else resolve();
});
});
expect(fs.statSync(path).mode & 0o7777).toBe(specialMode);
}
});

it("fchmod preserves special POSIX mode bits", async () => {
for (const input of inputs) {
const path = `${tmpdirSync()}/fchmodSpecialMode.txt`;
writeFileSync(path, "bun");

let fd = openSync(path, "w");
try {
fs.fchmodSync(fd, input);
expect(fstatSync(fd).mode & 0o7777).toBe(specialMode);
} finally {
closeSync(fd);
}

fd = openSync(path, "w");
try {
await new Promise<void>((resolve, reject) => {
fs.fchmod(fd, input, err => {
if (err) reject(err);
else resolve();
});
});
expect(fstatSync(fd).mode & 0o7777).toBe(specialMode);
} finally {
closeSync(fd);
}
}
});
});

function triggerDOMJIT(target: fs.Stats, fn: (..._: any[]) => any, result: any) {
for (let i = 0; i < 9999; i++) {
if (fn.apply(target) !== result) {
Expand Down