install: remove node_modules entries that left the lockfile - #32974
Open
robobun wants to merge 13 commits into
Open
install: remove node_modules entries that left the lockfile#32974robobun wants to merge 13 commits into
robobun wants to merge 13 commits into
Claude / Claude Code Review
completed
Jun 28, 2026 in 14m 6s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/install/PackageInstall.rs:2729-2756 |
prune_dangling_bin_links skips EntryKind::Unknown on DT_UNKNOWN filesystems |
Annotations
Check warning on line 2756 in src/install/PackageInstall.rs
claude / Claude Code Review
prune_dangling_bin_links skips EntryKind::Unknown on DT_UNKNOWN filesystems
nit: This `match entry.kind { EntryKind::SymLink => ... }` has the same `DT_UNKNOWN` gap that 0aee475 fixed for the `keep_symlinks` guards: on filesystems whose `readdir` doesn't populate `d_type` (NFS, FUSE, older XFS), every `.bin` entry is reported as `EntryKind::Unknown` and falls through to `_ => {}`, so the sweep is a no-op and the dangling links the prune just created survive. Fail-safe (leaves a broken link rather than deleting a good shim) and pre-existing on the `bun remove` path this
Loading